storybookjs/storybook

[Bug]: CLI templates for web-components are not actually using web components

Open

#21,142 opened on Feb 17, 2023

View on GitHub
 (2 comments) (4 reactions) (0 assignees)TypeScript (10,058 forks)batch import
bugclihelp wantedsev:S3web-components

Repository metrics

Stars
 (89,909 stars)
PR merge metrics
 (Avg merge 7d 22h) (184 merged PRs in 30d)

Description

Describe the bug

The CLI template are using functions that return lit html strings: https://github.com/storybookjs/storybook/blob/next/code/renderers/web-components/template/cli/js/Page.js

That is not a really common way to use lit and are not actual web components.

To Reproduce

No response

System

No response

Additional context

No response

Contributor guide

Research direction
Examine the CLI template files in code/renderers/web components/template/cli/ and replace function returning lit html with actual web component classes or custom elements.
Tech stack
typescriptjavascriptweb components
Domain
frontendcli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.jsStorybookLit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70