storybookjs/storybook

[Feature Request]: Drop dependency on `browser-assert`

Open

#21,408 opened on Mar 6, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (10,058 forks)batch import
help wantedmaintenancesecurity

Repository metrics

Stars
 (89,909 stars)
PR merge metrics
 (Avg merge 7d 22h) (184 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe

The package browser-assert which @storybook/builder-manager and @storybook/builder-webpack5 depend on has various issues according to: https://socket.dev/npm/package/browser-assert

Describe the solution you'd like

Remove the unmaintained dependency and write the 7 LOC yourself or use native methods.

Describe alternatives you've considered

No response

Are you able to assist to bring the feature to reality?

no

Additional context

No response

Contributor guide

Research direction
Find all imports of 'browser assert' in @storybook/builder manager and @storybook/builder webpack5, then replace with a simple inline assertion (e.g., if (typeof window === 'undefined') throw new Error(...)) and remove the dependency from package.json.
Tech stack
typescript
Domain
frontendtooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
npm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90