storybookjs/storybook

[Bug]: composition - CORS issues interactions addon

Open

#21,502 opened on Mar 9, 2023

View on GitHub
 (3 comments) (1 reaction) (0 assignees)TypeScript (10,058 forks)batch import
bugcompositionhelp wantedsev:S3

Repository metrics

Stars
 (89,909 stars)
PR merge metrics
 (Avg merge 7d 22h) (184 merged PRs in 30d)

Description

Describe the bug

Reported by @yannbf during QA:

Composed stories that contain the play function execute the play function correctly, but the interactions panel shows “no interactions” because of the following error:

DOMException: Blocked a frame with origin "http://localhost:6007/" from accessing a cross-origin frame.
at new Instrumenter (http://localhost:6007/node_modules/.cache/.vite-storybook/deps/@storybook_addon-interactions_preview.js?v=56a43576:712:93)

It looks like the 7.0 instrumenter still uses the pattern or trying to access the parent's frame: https://github.com/storybookjs/storybook/blob/62ccd7ec53ca82ab46e78aad0b4b42f147dd02ef/code/lib/instrumenter/src/instrumenter.ts#L103

It should not do this, or we just accept / document that the interactions addon isn't composition compatible.

To Reproduce

No response

System

No response

Additional context

No response

Contributor guide

Research direction
Investigate the instrumenter.ts file at line 103 and understand how it accesses parent frame. Modify to avoid cross origin access or document limitations.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35