storybookjs/storybook

[Bug]: Composition - component/stories count is off (it should skip docs types)

Open

#21,503 opened on Mar 9, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (10,058 forks)batch import
bugcompositionhelp wantedsev:S3

Repository metrics

Stars
 (89,909 stars)
PR merge metrics
 (Avg merge 7d 22h) (184 merged PRs in 30d)

Description

Describe the bug

Reported by @yannbf during QA:

It seems that the logic that shows amount of components and amount of stories is not accounting the new Docs 2.0 format. In this example, I have one unattached docs (1 story, if it is still considered a story) and one component (7 stories).

To Reproduce

@yannbf do you have this storybook with chroma pets published somewhere?

It's a nice minimal repro for this issue.

System

No response

Additional context

No response

Contributor guide

Research direction
Focus on the composition feature in Storybook. Investigate how the component and story counts are calculated, specifically the logic that filters out docs types added by Docs 2.0 format. Look for the relevant code in the monorepo, likely in the 'compose' or 'store' packages. Check if there are existing tests for counting logic. Reproduce the issue locally with a simple setup having unattached docs and a component with stories, then trace the count calculation.
Tech stack
typescriptreact
Domain
frontendtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
GitStorybookBasic React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50