storybookjs/storybook

[Bug]: Docs story wrapping issue with fixed positioned elements

Open

#23,586 opened on Jul 25, 2023

View on GitHub
 (17 comments) (2 reactions) (1 assignee)TypeScript (10,058 forks)batch import
has workaroundhelp wantedsev:S3upgrade:7.1

Repository metrics

Stars
 (89,909 stars)
PR merge metrics
 (Avg merge 7d 22h) (184 merged PRs in 30d)

Description

Describe the bug

Positioning in Docs page is broken for elements with fixed positioning.

Examples: Working deployment (7.0.6): https://storybook-7-0-6-reproduction.surge.sh/?path=/docs/uicomponents-date-picker-date-range--docs

Issue (7.1.0): https://storybook-7-1-0-reproduction.surge.sh/?path=/docs/uicomponents-date-picker-date-range--docs

image

Also found another comment here describing the same issue: https://github.com/storybookjs/storybook/issues/16774#issuecomment-1648367974

To Reproduce

Follow this reproduction link: https://codesandbox.io/p/sandbox/storybook-7-0-6-7-1-0-docs-issue-vkvwwy?file=%2Fpackage.json%3A21%2C27

You can switch the version 7.1.0 to 7.0.6 to reproduce this issue.

System

System:
    OS: Linux 5.15 Debian GNU/Linux 11 (bullseye) 11 (bullseye)
    CPU: (2) x64 AMD EPYC
  Binaries:
    Node: 16.17.0 - /usr/local/bin/node
    Yarn: 3.6.1 - /usr/local/bin/yarn
    npm: 8.15.0 - /usr/local/bin/npm
  npmPackages:
    @storybook/addon-essentials: 7.1.6 => 7.0.6 
    @storybook/addon-interactions: 7.1.6 => 7.0.6 
    @storybook/addon-links: 7.1.6 => 7.0.6 
    @storybook/addons: 7.1.6 => 7.0.6 
    @storybook/react: 7.1.6 => 7.0.6 
    @storybook/react-vite: 7.1.6 => 7.0.6

Additional context

Seems in <7.1.0 zoom was used, which was changed to transform and scale making this break 🤔

Contributor guide

Research direction
Compare the CSS changes between 7.0.6 and 7.1.0, focusing on how the switch from zoom to transform and scale affects fixed positioned elements in the Docs page. Trace the CSS property usage in the Storybook codebase and test the impact on absolute positioning.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CSSGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60