storybookjs/storybook

Addon-docs: Resize iframe to fit content

Open

#8,112 opened on Sep 18, 2019

View on GitHub
 (32 comments) (8 reactions) (2 assignees)TypeScript (10,058 forks)batch import
addon: docsblock: otherfeature requesthelp wantedtriage:reviewed

Repository metrics

Stars
 (89,909 stars)
PR merge metrics
 (Avg merge 7d 22h) (184 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe. Sometimes the component being displayed in Docs is only a few px tall, yet the iframe defaults to 500px. When you have a lot of these stories stacked, there is a lot of empty space.

Describe the solution you'd like After iframe loads, have it resize to fit the content

Describe alternatives you've considered Can set styles to manually override the iframe height per-story, but this is difficult/tedious to maintain

Contributor guide

Research direction
Research how to use postMessage to communicate iframe content height to the parent frame and dynamically adjust the iframe height after content loads.
Tech stack
typescript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70