strawberry-graphql/strawberry-django

`mutations.delete` and `mutations.update` do not support both `filters` _and_ `handle_django_errors`

Open

#544 opened on Jun 4, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (152 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (496 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the Bug

When handle_django_errors is turned on (either globally or for an individual mutation) for mutations.delete and mutations.update then filters on those mutations has no effect.

System Information

  • Operating system: Ubuntu
  • Strawberry version: 0.234.0
  • Strawberry Django version: 0.42.0

Additional Context

The problem is here: https://github.com/strawberry-graphql/strawberry-django/blob/90e1878959d83af471fc20d8f4c611ce2e767fa8/strawberry_django/filters.py#L320-L321

When handle_django_errors is turned on, is_list is no longer true, because the return type is now a union with OperationInfo. Additionally, the return type is now no longer even a list.

Contributor guide

Research direction
Investigate the filter logic in strawberry django/filters.py when handle django errors is enabled, focusing on how the return type changes from a list to a union with OperationInfo and how that affects filter application.
Tech stack
pythondjango
Domain
backendapidatabase
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonDjangoGraphQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70