swiftlang/swift

[SR-340] Refactor SILParser::parseSILInstruction

Open

#42,962 opened on Dec 22, 2015

View on GitHub
 (7 comments) (0 reactions) (1 assignee)Swift (10,719 forks)batch import
SILParsercompilergood first issuenfc

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-340
Radar None
Original Reporter @gottesmm
Type Bug
Status In Progress
Resolution
Votes 1
Component/s Compiler
Labels Bug, StarterBug
Assignee d066z (JIRA)
Priority Medium

md5: ee6df5ef735c9655c56ca6ce06200e7e

Issue Description:

parseSILInstruction is horrible and makes me cry every time I see it. It is a method that is ~1900 lines with a huge switch in it. We should refactor it into a visitor structure. In fact it is large enough that we should consider moving it into its own file if it is possible.

Contributor guide

Research direction
Familiarize yourself with the SILParser class, specifically the parseSILInstruction method. Analyze the current switch case structure and propose a visitor pattern to split the large method into smaller, more maintainable visitor methods. Consider moving the visitor to a separate file if possible.
Tech stack
swiftcpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitSwiftC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75