swiftlang/swift

[SR-2489] -resource-dir lib/swift/macosx should be treated as -resource-dir lib/swift/

Open

#45,094 opened on Aug 25, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Swift (10,719 forks)batch import
compilergood first issueimprovementlegacy driver

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-2489
Radar None
Original Reporter @belkadan
Type Improvement
Votes 0
Component/s Compiler
Labels Improvement, Driver, StarterBug
Assignee None
Priority Medium

md5: 55654e442cde4ed3e942cc7a23ba8985

Issue Description:

Although -resource-dir is pretty much only useful for people working on the compiler, it's a common mistake to pass a particular platform directory (like lib/swift/macosx/) instead of the whole thing (lib/swift/). The Swift driver could check for this (by looking for something that ought to be in lib/swift/) and popping up to the parent directory if it doesn't find it (with a warning).

Contributor guide

Research direction
Add a check in the Swift driver to verify that the resource dir path points to the base swift resource directory (e.g., lib/swift/) rather than a platform specific subdirectory (e.g., lib/swift/macosx/). If a platform subdirectory is detected, emit a warning and automatically use the parent directory.
Tech stack
swift
Domain
build system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80