swiftlang/swift

[SR-4294] Warn about overly-nested generic type specifiers

Open

#46,877 opened on Mar 20, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Swift (10,719 forks)batch import
bugcompilerdiagnostics qualitygood first issue

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-4294
Radar None
Original Reporter @jckarter
Type Bug
Votes 0
Component/s Compiler
Labels Bug, DiagnosticsQoI, StarterBug
Assignee None
Priority Medium

md5: c1aab4167ab2d03975e533b9a662698f

Issue Description:

https://twitter.com/steipete/status/843896945718546434

The tweet is in C++, but the same problem could affect Swift. A warning about overly-nested generic type specifiers that have enough piled-up closing >>>>>> brackets to be mistaken for a conflict marker in version control might be helpful, not only for tooling interaction, but for code cleanliness, since you should probably consider using a type alias at that point.

Contributor guide

Research direction
Look at the Swift compiler's diagnostic system to find where generic type specifiers are parsed and see if a warning can be added for overly nested generic types with many closing brackets.
Tech stack
swift
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85