swiftlang/swift

[SR-5742] Refactoring action to convert imperative code to functional style

Open

#48,312 opened on Aug 23, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Swift (10,719 forks)batch import
compilerfeaturegood first issuerefactoringsource tooling

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-5742
Radar rdar://32751280
Original Reporter @akyrtzi
Type New Feature
Votes 1
Component/s Source Tooling
Labels New Feature, Refactoring, StarterProposal
Assignee kacperh (JIRA)
Priority Medium

md5: d8dd54b6f1cfe6d2981c48e99ab5db6d

Issue Description:

Implement action to change code such as this:

func foo(list : [String]) {
  var result = [String]()

  for element in list {
    if !element.isEmpty {
      result.append(element)
    }
  }
}

to

func foo(list : [String]) {
  var result = list.filter { !$0.isEmpty }
}

Contributor guide

Research direction
Examine the Swift refactoring infrastructure, find existing refactoring actions as examples, and implement a new action that transforms imperative for in with filter condition into closure based filter call.
Tech stack
swift
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80