swiftlang/swift

[SR-7320] GYB is run with python, not python2.7

Open

#49,868 opened on Mar 31, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Swift (10,719 forks)batch import
bugcmakegood first issue

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-7320
Radar None
Original Reporter sanxiyn (JIRA User)
Type Bug
Votes 0
Component/s
Labels Bug, CMake, StarterBug
Assignee None
Priority Medium

md5: a456e83bcda5542ee8cf2382f8fa9b21

Issue Description:

https://github.com/apple/swift/pull/1535 made GYB run with python2.7, but https://github.com/apple/swift/pull/6463 effectively reverted the change because GYB is run with PYTHON_EXECUTABLE instead of using shebang line. This causes the problem 1535 fixed to reappear.

Contributor guide

Research direction
Identify where GYB is invoked in the CMake files and ensure it uses python2.7 instead of just python. Specifically, check the usage of PYTHON EXECUTABLE and set it to python2.7 if necessary.
Tech stack
swiftpython
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CMake
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80