swiftlang/swift

[SR-8147] Fixit corrects .eventTrackingRunLoopMode to .RunLoop.Mode.eventTracking with invalid leading period

Open

#50,679 opened on Jun 29, 2018

View on GitHub
 (21 comments) (0 reactions) (0 assignees)Swift (10,719 forks)batch import
bugcompilerdiagnostics qualitygood first issue

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-8147
Radar rdar://problem/41545427
Original Reporter @jckarter
Type Bug

Attachment: Download
Votes 0
Component/s Compiler
Labels Bug, DiagnosticsQoI, StarterBug
Assignee None
Priority Medium

md5: 8dc18aea989964e226ca7f5bd1d9df9f

Issue Description:

Compiling the following code emits a fixit to change ‘.eventTrackingRunLoopMode’ to ‘.RunLoop.Mode.eventTracking’ with a leading period which does not compile since the type is fully specified already.

import AppKit

func foo(timer: Timer) {
  RunLoop.current.add(timer, forMode: .eventTrackingRunLoopMode)
}

Contributor guide

Research direction
Investigate the fix it logic in the Swift compiler that suggests '.RunLoop.Mode.eventTracking' with a leading period. Examine the relevant source file in lib/Sema or lib/IDE to understand why the period is added and ensure the fix it is correct for fully specified types.
Tech stack
swift
Domain
None
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Swift
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60