swiftlang/swift

[SR-9216] Don't honor SDKROOT in interpreter mode

Open

#51,705 opened on Nov 9, 2018

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Swift (10,719 forks)batch import
bugcompilergood first issuelegacy driver

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-9216
Radar rdar://problem/21819253
Original Reporter @belkadan
Type Bug
Votes 1
Component/s Compiler
Labels Bug, Driver, StarterBug
Assignee Jon (JIRA)
Priority Medium

md5: f3641cf6b439af1689bb8109248eccef

Issue Description:

People have tried to use Swift in Xcode Run Script build phases, but because Swift looks at the SDKROOT environment variable, the Run Script phase will fail when building a non-macOS target:

<unknown>:0: warning: using sysroot for 'iPhoneOS' but targeting 'MacOSX'
<unknown>:0: error: unable to load standard library for target 'x86_64-apple-macosx10.14'

We should just ignore SDKROOT when running the interpreter. Swift knows how to invoke xcrun to find the right SDK when it's not passed one explicitly.

Contributor guide

Research direction
Modify the Swift driver to ignore the SDKROOT environment variable when running in interpreter mode. Look for where SDKROOT is used and conditionally skip it.
Tech stack
swift
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Swiftcommand line tools
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75