swiftlang/swift

[SR-9336] importing structures with anonymous fields crashes the ClangImporter

Open

#51,806 opened on Nov 25, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Swift (10,719 forks)batch import
AndroidLinuxWindowscompilergood first issueimprovement

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-9336
Radar None
Original Reporter @compnerd
Type Improvement
Votes 0
Component/s Compiler
Labels Improvement, Android, ClangImporter, Linux, StarterBug, Windows
Assignee None
Priority Medium

md5: e340d6800850b57905470aa79f4a8815

Issue Description:

Seems that the typo correction on windows asserts trying to create an anonymous field accessor. This occurred at least in Data.swift in swift-corelibs-foundation trying to typo correct munmap.

Contributor guide

Research direction
Inspect the crash in ClangImporter when importing structures with anonymous fields. Trace the typo correction path on Windows.
Tech stack
swiftc
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
SwiftCcompiler concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75