swiftlang/swift

[SR-12930] Add protocol extension to "Result where Success == Void" so that we can use .success()

Open

#55,376 opened on Jun 3, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Swift (10,719 forks)batch import
good first issueimprovementstandard libraryswift evolution proposal needed

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-12930
Radar None
Original Reporter ronyfadel (JIRA User)
Type Improvement
Votes 0
Component/s Standard Library
Labels Improvement, StarterProposal
Assignee None
Priority Medium

md5: 176bf2fbbef4e6b7e54e92d66bdb68aa

Issue Description:

Currently, to signal a success of type Result<Void, Swift.Error>, we need to use:

.success(())

Combine, for example, special-cases Subject for when the Output is of type Void:

extension Subject where Self.Output == Void {
    /// Signals subscribers.
    public func send()
}

A similar extension could be added for `Result` so that we can use .success(()) instead:

extension Result where Success == Void {
    static func success() -> Self {
        return .success(())
    }
}

I'd be happy to contribute a patch if someone can point me to the proper PR policy.

Contributor guide

Research direction
Locate the Result type in the Swift standard library source and add the extension method for Void success. Refer to contribution guidelines for Swift project.
Tech stack
swift
Domain
None
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Swift
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90