swiftlang/swift

[SR-13388] Add Fix-Its to "override" mismatch

Open

#55,828 opened on Aug 13, 2020

View on GitHub
 (9 comments) (0 reactions) (0 assignees)Swift (10,719 forks)batch import
compilergood first issueimprovement

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-13388
Radar rdar://problem/66539331
Original Reporter @DougGregor
Type Improvement
Status In Progress
Resolution
Votes 0
Component/s Compiler
Labels Improvement, StarterBug
Assignee RoyCao (JIRA)
Priority Medium

md5: be871146c13ac26dbbf04275c83c2233

Issue Description:

For code like this following:

class Base {
  func foo(a: Int, b: Int) {}
}
class C: Base {
  override func foo(a: Int) {} // error: method does not override any method from its superclass
}

we should provide a Fix-It that adds ", b: Int" to C.foo.

Contributor guide

Research direction
Examine the existing fix it mechanism in the Swift compiler and implement a new fix it that suggests adding missing parameters for method override mismatches.
Tech stack
swift
Domain
compilers
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Swift
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80