swiftlang/swift

[SR-15176] Fixit for `override func` that should be `override var`

Open

#57,499 opened on Sep 9, 2021

View on GitHub
 (31 comments) (0 reactions) (1 assignee)Swift (10,719 forks)batch import
compilerdiagnostics qualityfix-itsgood first issueimprovementinheritanceoverrideswift 5.9

Repository metrics

Stars
 (69,989 stars)
PR merge metrics
 (Avg merge 8d 17h) (510 merged PRs in 30d)

Description
Previous ID SR-15176
Radar rdar://28337871
Original Reporter @CodaFi
Type Improvement
Votes 0
Component/s Compiler
Labels Improvement, DiagnosticsQoI, StarterBug
Assignee jiaren wang (JIRA)
Priority Medium

md5: b17661d61829d04b65f822d78b07388a

Issue Description:

Consider

class C {
  var canBecomeFirstResponder: Bool

  init() {}
}

class D: C {
    override func canBecomeFirstResponder() -> Bool {
    }
}

We should add a special case to diagnoseGeneralOverrideFailure that tries to see if it can correct no-args FuncDecls to VarDecls and vice-versa.

Contributor guide

Research direction
Examine the `diagnoseGeneralOverrideFailure` function in the Swift compiler's source code. Look for how it currently handles overrides and identify where to add a check to suggest converting `override func` to `override var` (and vice versa) when a method with no parameters matches a property.
Tech stack
swift
Domain
compilers
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Swiftcompiler diagnostics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80