thedevdojo/voyager

Create decimal fields with precision

Open

#3,793 opened on Dec 7, 2018

View on GitHub
 (14 comments) (2 reactions) (0 assignees)PHP (2,652 forks)batch import
help wantedtype:bug

Repository metrics

Stars
 (11,817 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Version information

  • Laravel: v5.7
  • Voyager: v1.1.10
  • PHP: 7.x
  • Database: mysql 5.7

Description

If you create a field type decimal, you can't add precision, like 10,8

Steps To Reproduce

Create a field type decimal, if you try to add length to 10,8 it store as 10,0

Expected behavior

Should store decimal precision

Contributor guide

Research direction
Search for how Voyager creates decimal columns in its BREAD Builder and check if precision is passed correctly to Laravel's schema builder.
Tech stack
phplaravel
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPLaravelMySQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60