tlsfuzzer/tlslite-ng

duplicated code in Python_RSAKey

Open

#427 opened on Oct 18, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (95 forks)auto 404
good first issuehelp wanted

Repository metrics

Stars
 (269 stars)
PR merge metrics
 (PR metrics pending)

Description

The code in __init__: https://github.com/tlsfuzzer/tlslite-ng/blob/9951ec1c769617247a80aa1cae661ec0edc68823/tlslite/utils/python_rsakey.py#L16-L54 and the code in generate(): https://github.com/tlsfuzzer/tlslite-ng/blob/9951ec1c769617247a80aa1cae661ec0edc68823/tlslite/utils/python_rsakey.py#L110-L135

perform the same operations. generate() could be reduced to calculating just p, q, n, and selecting e, passing them to Python_RSAKey constructor, so that __init__ calculates the d, dP, dQ, and qInv.

Contributor guide

Research direction
Review the duplicated code in init and generate() methods of Python RSAKey. The goal is to refactor generate() to only compute p, q, n, and e, then pass those to the constructor so init handles the remaining calculations (d, dP, dQ, qInv). Ensure that the refactoring does not change the functionality.
Tech stack
python
Domain
securitybackend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70