trinodb/trino

Do not override docker image configuration in testing images

Open

#1,978 opened on Nov 7, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Java (2,678 forks)batch import
good first issue

Repository metrics

Stars
 (9,113 stars)
PR merge metrics
 (Avg merge 5d 9h) (306 merged PRs in 30d)

Description

Example, one image provides hadoop and so it contains core-site.xml, then that image is used as base for another image (with some additional feature like KRB) and then it overrides core-site.xml. This approach makes it very unclear what actually has changed between these images.

One idea to fix this is to use apply-site-xml-override.sh from https://github.com/prestosql/presto/pull/1958#discussion_r343593949

Contributor guide

Research direction
Study the Dockerfile chain in testing/images to understand how base images are used and how core site.xml is overridden. Look at the referenced PR #1958 for the apply site xml override.sh approach. Determine where each image is built and where the override occurs.
Tech stack
javadocker
Domain
backenddatadevops
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
DockerGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70