good first issuemaintenance
Repository metrics
- Stars
- (9,113 stars)
- PR merge metrics
- (Avg merge 5d 9h) (306 merged PRs in 30d)
Description
The checks are defined here: https://github.com/prestosql/presto/blob/fcb91631a655f8af7c6aeb803861d1c738f67281/pom.xml#L1424
Here's how to run the checks: https://github.com/prestosql/presto/blob/fcb91631a655f8af7c6aeb803861d1c738f67281/.github/workflows/ci.yml#L72-L73
- Enable on error level:
- EqualsIncompatibleType (https://github.com/prestosql/presto/pull/4181)
- NullOptional
- BadInstanceof
- BoxedPrimitiveConstructor (https://github.com/prestosql/presto/pull/4269)
- CompareToZero
- OptionalEquality (https://github.com/trinodb/trino/pull/6562)
- UnusedVariable (https://github.com/prestosql/presto/pull/5642)
- InconsistentHashCode
- ImmutableEnumChecker, ImmutableAnnotationChecker (https://github.com/prestosql/presto/pull/4470)
- ObjectToString
- UnnecessaryParentheses
- Enable MissingCasesInEnumSwitch errorprone check #6764
- DefaultCharset (warning: this one is tricky)
- ...
- Enable format checks on loggers (https://github.com/prestosql/presto/issues/4189)
- Enable errorprone's default checks (remove
-XepDisableAllChecks)- hint: this may require multiple changes in the source code to address multiple checks, so it's good idea to do this step by step in multiple PRs.
- ... -- we may propose some other checks that errorprone does not run on error level by default, see http://errorprone.info/bugpatterns#on-by-default--warning