trinodb/trino

Wrong exception when calling ResultSet.getTimestamp on TIME value

Open

#5,315 opened on Sep 28, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Java (2,678 forks)batch import
good first issuejdbc

Repository metrics

Stars
 (9,113 stars)
PR merge metrics
 (Avg merge 5d 9h) (306 merged PRs in 30d)

Description

java.lang.IllegalArgumentException: Expected column to be a timestamp type but is time(3)
	at io.prestosql.jdbc.AbstractPrestoResultSet.getTimestamp(AbstractPrestoResultSet.java:362)
	at io.prestosql.jdbc.AbstractPrestoResultSet.getTimestamp(AbstractPrestoResultSet.java:327)
	at io.prestosql.jdbc.PrestoResultSet.getTimestamp(PrestoResultSet.java:44)

should be SQLException

Contributor guide

Research direction
Locate the method `getTimestamp` in `AbstractPrestoResultSet.java`, change the thrown exception from `IllegalArgumentException` to `SQLException` with appropriate SQLState and message, and add a test case verifying the behavior.
Tech stack
java
Domain
backenddatabaseapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaJDBCGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60