trinodb/trino

Support setting column comment when creating table in JDBC based connector

Open

#5,334 opened on Sep 29, 2020

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Java (2,678 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (9,113 stars)
PR merge metrics
 (Avg merge 5d 9h) (306 merged PRs in 30d)

Description

Currently, it's ignored silently. We need to consider some RDBMS doesn't support setting a column comment in CREATE TABLE (e.g. PostgreSQL).

https://github.com/prestosql/presto/blob/22717c61419c851b1c3814b60a3453b22d4a45ef/presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/BaseJdbcClient.java#L477

https://github.com/prestosql/presto/blob/22717c61419c851b1c3814b60a3453b22d4a45ef/presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/BaseJdbcClient.java#L500-L510

Contributor guide

Research direction
Examine the current CREATE TABLE logic in BaseJdbcClient and implement column comment support via JDBC DatabaseMetaData or dialect specific SQL, using the column comment from the connector's metadata.
Tech stack
java
Domain
backendapidatabase
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaJDBC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60