trixi-framework/Trixi.jl

Automate EC/ES tests

Open

#903 opened on Oct 10, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Julia (153 forks)batch import
hacktoberfesttesting

Repository metrics

Stars
 (686 stars)
PR merge metrics
 (Avg merge 19d 17h) (36 merged PRs in 30d)

Description

This came up one again in https://github.com/trixi-framework/Trixi.jl/pull/900#discussion_r725094522. If someone wants to earn a T-shirt, this would be a nice Hacktoberfest project. The idea would be to add an optional keyword argument test_ec to @test_trixi_include with default value false. If test_ec is set to true (or a non-zero tolerance), we should perform an automatic check whether semidiscrete entropy-conservation (EC) holds. It would probably be sufficient to just test the final numerical solution.

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.