tursodatabase/libsql-client-ts

Remote databases don't support raw error code

Open

#117 opened on Oct 18, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (67 forks)auto 404
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (566 stars)
PR merge metrics
 (PR metrics pending)

Description

I disabled the raw error code tests in 846b2d0fc2f80fc9cb87bb1db4158857e8c7f54f for remote databases because we never set the error code for remote database errors:

export function mapHranaError(e: unknown): unknown {
    if (e instanceof hrana.ClientError) {
        const code = mapHranaErrorCode(e);
        return new LibsqlError(e.message, code, undefined, e);
    }
    return e;
}

(It's the undefined there after code when constructing LibsqlError)

Contributor guide

Research direction
Inspect the mapHranaError function and modify it to pass the error code (e) as the third argument to LibsqlError instead of undefined.
Tech stack
typescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75