twolfson/firefox-bookmarks

firefox-bookmarks flatten --filename error.

Open

#3 opened on Aug 8, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (1 fork)github user discovery
bughelp wanted

Repository metrics

Stars
 (12 stars)
PR merge metrics
 (PR metrics pending)

Description

Hi and thanks for this nice tool you developed. I get the following error while trying the cli option on windows.

Is it an empty folder maybe?

Thanks a lot, Nikolas

`C:\Users\user\AppData\Roaming\npm\node_modules\firefox-bookmarks\lib\firefox-bookmarks.js:35 var bookmarkFolders = bookmarkMenu.children; ^

TypeError: Cannot read property 'children' of undefined at Function.BookmarkCollection.parse (C:\Users\user\AppData\Roaming\npm\node_modules\firefox-bookmarks\lib\firefox-bookmarks.js:35:38) at new BookmarkCollection (C:\Users\user\AppData\Roaming\npm\node_modules\firefox-bookmarks\lib\firefox-bookmarks.js:10:38) at C:\Users\user\AppData\Roaming\npm\node_modules\firefox-bookmarks\lib\cli.js:63:26 at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:511:3) `

Contributor guide

Research direction
Investigate why bookmarkMenu.children is undefined. The issue may occur when the bookmark folder has no children or is empty. Ensure the parse method handles missing or empty bookmarkMenu gracefully.
Tech stack
javascriptnodejs
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85