twolfson/google-music.js

Implement/Fix Podcasts

Open

#49 opened on Jul 22, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (6 forks)github user discovery
bugenhancementhelp wanted

Repository metrics

Stars
 (47 stars)
PR merge metrics
 (PR metrics pending)

Description

I might be able to tackle this soon, but the current API does not handle Podcasts.

Things that need to be fixed:

  1. The album querySelector fails when podcasts are playing because the element doesn't exist, causing the songInfo API to not return results.
  2. There is also two new buttons, rewind-10 and forward-30 that are not implemented.
  3. We should implement an API method such as isPodcast which can be tracked by checking the current .now-playing-actions for the class podcast.
  4. There are no ratings for podcasts, so those setters/getters "break" as well.

I'm not sure of the feasibility of adding tests as Podcasts are regionally available and we can't upload a podcast (afaik) to test metadata and the new buttons. We may have to settle for finding a podcast and navigating to it directly in order to test.

Contributor guide

Research direction
Investigate how Google Music web player handles podcasts by inspecting DOM elements like `.now playing actions` for `podcast` class. Determine alternative ways to detect podcast playback and handle missing `album` element. Consider implementing `isPodcast` method and handling rewind 10 and forward 30 buttons. For testing, manually navigate to a podcast in the player.
Tech stack
javascript
Domain
api
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60