uber-go/nilaway

Add support for rich effect functions via function pointers

Open

#277 opened on Sep 4, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (92 forks)auto 404
false positivegood first issue

Repository metrics

Stars
 (3,862 stars)
PR merge metrics
 (PR metrics pending)

Description

NilAway currently does not recognize function pointers as valid rich check effect functions, thereby reporting false positives.

type S struct {
	f func() (*int, error)
}

func testme(s *S) {
	v, err := s.f()
	if err != nil {
		return
	}
	_ = *v // FP: unassigned variable `v` dereferenced
}

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.