ungoogled-software/ungoogled-chromium

Revise patches to fix compiler warnings?

Open

#1,682 opened on Oct 9, 2021

View on GitHub
 (5 comments) (2 reactions) (0 assignees)Python (771 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (18,674 stars)
PR merge metrics
 (Avg merge 1d 11h) (9 merged PRs in 30d)

Description

I've been seeing this for awhile now. The patches maintained here cause the new code to produce compiler warnings in downstream repositories. Should an effort be made to modify the changes so these warnings can be properly addressed?

Contributor guide

Research direction
Inspect the downstream compiler warnings and apply fixes to the patches to eliminate them.
Tech stack
cpp
Domain
backendbuild system
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Gitcpp
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50