ungoogled-software/ungoogled-chromium

Compatibility with debug builds

Open

#914 opened on Jan 19, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (771 forks)batch import
bugenhancementhelp wanted

Repository metrics

Stars
 (18,674 stars)
PR merge metrics
 (Avg merge 1d 11h) (9 merged PRs in 30d)

Description

This is a discussion, probably related to https://github.com/Eloston/ungoogled-chromium/issues/845 and https://github.com/Eloston/ungoogled-chromium/issues/897.

I have noticed that the set of patches in their current condition breaks debugging builds (is_debug=1), at least for Linux and Android versions, almost every time. It is not a big issue for end users but it makes debugging a lot more inconvenient as every time I need to find the problems and change the codes manually. So I am thinking probably we can add a set of patches designated for debugging, or somehow incorporate them within the other patches?

Contributor guide

Research direction
Examine the existing patches that break debug builds, identify common issues, and propose a set of patches that are conditionally applied only for debug builds.
Tech stack
pythoncpp
Domain
developer experiencebuild system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitChromium build system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65