uqbar-project/wollok-language

Try to avoid abstract and native methods in abstract classes as much as possible

Open

#29 opened on Nov 9, 2019

View on GitHub
 (0 comments) (0 reactions) (2 assignees)Wollok (14 forks)auto 404
good first issuehelp wantedquestion

Repository metrics

Stars
 (8 stars)
PR merge metrics
 (PR metrics pending)

Description

Extracted from discussion on #26 .

This ticket is being made specially thinking in Collections, but might apply to other places.

Currently, collection defines many abstract and some native methods (such as findOrElse(predicate, continuation)).

I believe it would be a better idea to implement as many as these methods as possible, even if it's in a naive way. This would allow some implementations to delegate on this implementations if performance is not an issue and would provide good defaults for new Collection subclasses.

Well known subclasses as Set, Dictionary and List could override these methods with natives as needed, so there would be no performance impact.

Contributor guide

Research direction
Study the current abstract and native methods in the Collection class hierarchy and implement default naive implementations for them.
Tech stack
None
Domain
compilers
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30