velero-io/velero

Improve the `velero plugin` command

Open

#2,427 opened on Apr 13, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (1,550 forks)auto 404
Area/CLIEnhancement/UserHelp wantedIceboxReviewed Q2 2021kind/requirement

Repository metrics

Stars
 (10,111 stars)
PR merge metrics
 (PR metrics pending)

Description

Add this flag:

set
        --sa-annotations mapStringString        annotations to add to the Velero ServiceAccount for GKE. Add iam.gke.io/gcp-service-account=[GSA_NAME]@[PROJECT_NAME].iam.gserviceaccount.com for workload identity. Optional. Format is key1=value1,key2=value2

Note: it currently exists under velero install.

Contributor guide

Research direction
Examine the existing `velero install` command's ` sa annotations` flag implementation and replicate it for the `velero plugin` command, updating the command's flag set and documentation accordingly.
Tech stack
go
Domain
clibackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoKubernetes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65