velero-io/velero

Enabled linters with all options set to false

Open

#7,801 opened on May 16, 2024

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (1,550 forks)auto 404
Help wantedbacklog

Repository metrics

Stars
 (10,111 stars)
PR merge metrics
 (PR metrics pending)

Description

What steps did you take and what happened:

Linters enabled in config file are used to make project better. But enabling them with all options set to false is the same as not enabling them at all.

Linters enabled but with all their options set to false:

  • errcheck
  • revive
  • unparam

Anything else you would like to add:

Related to https://github.com/vmware-tanzu/velero/issues/6023

Environment:

  • development environment

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • :+1: for "I would like to see this bug fixed as soon as possible"
  • :-1: for "There are more important bugs to focus on right now"

Contributor guide

Research direction
Examine the .golangci.yaml file for the listed linters (errcheck, revive, unparam) and ensure their configurations are meaningful; either set appropriate options or disable the linters if not used. Reference the discussion in issue #6023 for context.
Tech stack
go
Domain
devops
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85