vimeo/psalm

`str_replace()` with more search then replace values

Open

#4,253 opened on Sep 28, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)PHP (668 forks)batch import
Help wantedenhancementtype providers

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (Avg merge 3d 12h) (5 merged PRs in 30d)

Description

even if it is supported by php-src, I think it should be an error (or at least warning) when using str_replace with less replace args, then search args. its most likely a typo and the default behaviour of php-src assuming we want to replace with an empty string is not obvious.

I expect an error, telling me that the number of replace args is not equal with the number of search args in https://psalm.dev/r/7385fe7881

Contributor guide

Research direction
Research how Psalm detects issues in function calls. Look at existing implementations for similar built in functions (e.g., array functions) and create a new check for str replace that emits a warning when the number of search parameters exceeds the number of replace parameters.
Tech stack
php
Domain
devtools
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65