vimeo/psalm

MissingTemplateParam triggered by calling code

Open

#6,870 opened on Nov 9, 2021

View on GitHub
 (13 comments) (0 reactions) (0 assignees)PHP (668 forks)batch import
easy problemsenhancementgood first issue

Repository metrics

Stars
 (5,369 stars)
PR merge metrics
 (Avg merge 3d 12h) (5 merged PRs in 30d)

Description

Psalm version 4.12.0

ERROR: MissingTemplateParam - app/Services/ReportBuilder.php:126:19 - ArrayObject has missing template params, expecting 2 (see https://psalm.dev/182)
      $drawings = $sheeet->getDrawingCollection();

The problem is with the PhpSpreadsheet Worksheet class which only templates one argument.

I tried to make a simplified test case for this and it didn't work. This was the attempt. https://psalm.dev/r/1a3c9bae46

Contributor guide

Research direction
Inspect the simplified test case at https://psalm.dev/r/1a3c9bae46 and trace the logic in Psalm that triggers MissingTemplateParam for classes like ArrayObject with missing template params. Understand how Psalm resolves template parameters for built in classes and identify why it expects 2 parameters for ArrayObject but only 1 is provided.
Tech stack
php
Domain
backendtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60