xtermjs/xterm.js

Support 'px' format in lineHeight option

Open

#2,612 opened on Dec 6, 2019

View on GitHub
 (5 comments) (1 reaction) (1 assignee)TypeScript (1,574 forks)batch import
good first issuehelp wantedtype/enhancement

Repository metrics

Stars
 (16,196 stars)
PR merge metrics
 (Avg merge 2d 10h) (16 merged PRs in 30d)

Description

Now the LineHeight can only be propagated to the number type like 1.2.

There is a very uncomfortable scenario:

I chose to use DOM to render，Then the contents of the subdiv of xterm-rows, as shown below, are determined based on the configuration items, such as 1.2, and the calculated value is 21px：

image

I want to set LineHeight to 23px, then I need to set LineHeight to 1.3, but I don't know how to turn 23 to 1.3

Contributor guide

Research direction
Examine how lineHeight is currently used in xterm.js rendering code, then implement support for 'px' format by parsing the value and converting to a multiplier if needed.
Tech stack
typescript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75