yogthos/Selmer

Minify HTML before caching

Open

#221 opened on Apr 9, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Clojure (121 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (1,042 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Is it possible to hook up a minifier before caching the template?

I was looking at gluing Selmer and this: https://github.com/yogthos/asset-minifier (more specifically this) but it seems that I would have to run the minifcation on top of Selmer's already cached content?

The thing I am trying to avoid is having to cache twice, or having to run minifcation on requests themselves.

Or should I manually minify the template itself after each edit?

(did I say minify enough times?)

Contributor guide

Research direction
Examine how Selmer caches templates and identify where a minification step can be added before caching. Look at the cache configuration and consider using asset minifier or clj html compressor.
Tech stack
clojure
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Clojure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70