yogthos/migratus

Migration fails if a comment is present on line with semicolon

Open

#208 opened on Jan 14, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Clojure (99 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (686 stars)
PR merge metrics
 (PR metrics pending)

Description

A migration like

select 2; -- Thing

will fail with the error

2022-01-13T18:58:54.278Z Skrutten ERROR [migratus.migration.sql:326] - failed to execute command:
 
select 2; -- Thing

2022-01-13T18:58:54.278Z Skrutten ERROR [migratus.migration.sql:326] - Too many update results were returned.
2022-01-13T18:58:54.278Z Skrutten ERROR [migratus.database:326] - Migration odlingshistorik failed because Batch entry 1 <unknown> was aborted: Too many update results were returned.  Call getNextException to see other errors in the batch. backing out
2022-01-13T18:58:54.280Z Skrutten INFO [migratus.core:326] - Ending migrations
Execution error (PSQLException) at org.postgresql.jdbc.BatchResultHandler/handleCommandStatus (BatchResultHandler.java:102).
Too many update results were returned.

while a migration like

select 1, -- Thing
2;

will work just fine. My guess would be that some sort of line splitting on semicolons is at hand, but that is just a wild guess.

Contributor guide

Research direction
Investigate the SQL migration parsing logic in the codebase, focusing on how lines are split on semicolons and how comments are handled. Trace the execution path to identify why a comment on the same line as a semicolon causes a failure.
Tech stack
clojuresql
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ClojureSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65