zulip/zulip-mobile

Add support for composing "silent mentions"

Open

#3,374 opened on Feb 28, 2019

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (673 forks)github user discovery
a-compose/sendapi migrationshelp wanted

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (PR metrics pending)

Description

We recently added a new markdown syntax for "silent mentions", spelled @_**Tim Abbott**. We should extend the mobile app typeahead to complete that if the user starts their mention typeahead with @_.

(The HTML generated is very similar to the HTML for normal mentions, displayed as a bubble around "Tim Abbott" (no @) with markup matching a normal mention + an extra silent CSS class that we can use for future styling changes if desired, so I expect no changes are required to support displaying these properly)

Contributor guide

Research direction
Examine the existing mention typeahead implementation (likely in a file like `MentionsInput` or `AutocompleteView`). Add a new case for `@ ` that triggers the same mention autocomplete results but generates a silent mention syntax `@ **Name**` instead of `@**Name**`. Look at the backend response or mock data for mention candidates.
Tech stack
javascript
Domain
mobile
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70