zulip/zulip-mobile

Add support for disabling file upload

Open

#3,477 opened on May 8, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (673 forks)github user discovery
api migrationshelp wanted

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (PR metrics pending)

Description

This is not super high priority, but I wanted to open an issue so we don't forget about it as it might be pretty simple as well.

We have a (new in the last week) parameter in the /register response, max_file_upload_size, which is the limit on how big a file one can upload. When that parameter is 0, we should disable showing the "attach files" option in the app for a given organization.

https://github.com/zulip/zulip/pull/12267/files is the webapp PR for this.

Contributor guide

Research direction
Look at how the /register response is processed, find where max file upload size is used, and conditionally hide the 'attach files' option when it is 0. Reference the webapp PR for implementation details.
Tech stack
javascriptreact native
Domain
mobile
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75