zulip/zulip-mobile

Update implementation for subject_links -> topic_links transition

Open

#3,884 opened on Feb 7, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (673 forks)github user discovery
api migrationsexperimental UI/UXhelp wanted

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (PR metrics pending)

Description

In https://github.com/zulip/zulip/pull/13843 merged for Zulip 2.2, we migrated the server from the legacy subject_links field (named after the legacy "subject" field name) to topic_links.

My understanding is the mobile app never used the feature; in the webapp it is used to render the little link boxes that show up if you have a link or a reference to a linkifier in the message's topic (we need a separate widget because clicking on the topic itself navigates to that topic). I'm not sure what the mobile UI would be for this feature, but probably something in a long-press menu or something.

So this is mainly an issue so you can migrate references in the codebase types, and maybe write a shim to support older servers while one is thinking about this.

A correct backwards-compatability approach for servers 2.1 and older would be to copy a subject_links field to topic_links if present.

Contributor guide

Research direction
Examine the codebase for all references to `subject links` and implement a compatibility layer to map the old field to `topic links` for servers running version 2.1 or earlier.
Tech stack
javascriptreact native
Domain
mobile
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60