zulip/zulip-mobile

Use realm icons in organization switcher

Open

#392 opened on Feb 26, 2017

View on GitHub
 (13 comments) (0 reactions) (0 assignees)JavaScript (673 forks)github user discovery
a-multi-orgexperimental UI/UXhelp wanted

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (PR metrics pending)

Description

We just merged into master and deployed to chat.zulip.org https://github.com/zulip/zulip/pull/3740, which adds support for admin-uploaded realm icons. Realm icons are the same size as avatars, 100x100.

The URL is available in the /register request request, if we have realm in the want list, which I assume we already have since it contains useful settings data.

There are 2 fields that adds to the /register response:

  • realm_icon_url (the URL for the realm's icon, all we should need). This will always be present even if the user hasn't customized it (will fall back to gravatar), but only on the very latest server versions (effectively 1.6); we should put in some form of constant fallback I guess for older servers.
  • realm_icon_source (needed only for the admin UI to change it, since this controls whether to show the "delete and go back to gravatar button")

Contributor guide

Research direction
Examine the /register response structure to find realm icon url. Update the organization switcher component to fetch and display the realm icon using the URL. Add a fallback for older servers where the field might be absent.
Tech stack
javascriptreact native
Domain
mobile
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
React NativeRedux
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70