zulip/zulip-mobile

Change in how muted_topics tuples are represented

Open

#4,044 opened on Apr 15, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (673 forks)github user discovery
api migrationshelp wanted

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (PR metrics pending)

Description

We added an additional field, date_muted, at the end of muted_topics tuples, in https://github.com/zulip/zulip/commit/9340cd1a0b7af7af9b83a622e37d02f1a2340609 as part of https://github.com/zulip/zulip/pull/13833.

Opening an issue here. Ultimately, we don't use tuples anywhere else for a reason, and may want to change the interface further, but this should at least be backwards-compatible.

See https://github.com/zulip/zulip/pull/13833#discussion_r375878827 for testing that it doesn't break the existing mobile app to have made this change.

Contributor guide

Research direction
Review the referenced commit and PR to understand the change in muted topics tuples and test the mobile app for backwards compatibility.
Tech stack
javascript
Domain
mobile
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65