zulip/zulip-mobile

Add CSS for new hl_lines feature of code blocks if needed

Open

#4,564 opened on Mar 26, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (673 forks)github user discovery
a-message listapi migrationshelp wanted

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (PR metrics pending)

Description

We're close to merging https://github.com/zulip/zulip/pull/16984, which will add support for the pygments hl_lines feature (being able to highlight lines in a markdown code block). It's probably OK to ignore the composition/local echo parts of this new feature and just expect to get that as part of future syncing code from the webapp project.

We should test how that new feature looks in the mobile app, and if it's ugly, fix it. (The original PR has night them styling that may be useful as well).

As a sidenote, is it useful to document features like this in the API changelog?

Contributor guide

Research direction
Run the mobile app, test code blocks with highlighted lines, and adjust CSS if needed.
Tech stack
javascriptreact native
Domain
mobile
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60