zulip/zulip-mobile

Allow editing in all types of narrows

Open

#4,671 opened on Apr 17, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (673 forks)github user discovery
a-compose/sendhelp wanted

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (PR metrics pending)

Description

From src/message/messageActionSheet.js:

  if (
    message.sender_id === ownUser.user_id
    // Our "edit message" UI only works in certain kinds of narrows.
    && (isStreamOrTopicNarrow(narrow) || isPmNarrow(narrow))
  ) {
    buttons.push(editMessage);
  }

It would be nice if editing worked in all types of narrows.

I think the easiest solution here is to just narrow to the relevant topic or PM narrow and then show the edit box, but we could also just fix the edit box so it works everywhere.

Contributor guide

Research direction
Investigate the current edit button logic in src/message/messageActionSheet.js. The goal is to enable editing in all narrows. Two approaches: (1) Navigate to the relevant stream/topic or PM narrow when edit is pressed, then show the edit box; (2) Modify the edit UI component to work without narrow constraints. Choose the most appropriate approach and implement. Ensure tests pass.
Tech stack
javascriptreact native
Domain
mobile dev
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65