zulip/zulip-mobile

Ignore fake emails in user search and typeahead

Open

#4,889 opened on Jul 8, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (673 forks)github user discovery
P1 high-prioritybughelp wanted

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (PR metrics pending)

Description

In organizations where emails are not public, we create fake "emails" with unique user IDs. At present, these emails are queried in user search and typeahead, which is certainly not what the user intends. Along with #4869, it makes user search feel "broken".

If email address visibility for an organization is something other than "everyone", we should ignore the email field in user search.

Contributor guide

Research direction
Identify where user search queries emails and add a check for organization email visibility setting before including email field in search.
Tech stack
javascriptreact native
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReact Native
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75