zulip/zulip-mobile

Unread-PMs count is blank if too big

Open

#4,904 opened on Jul 17, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (673 forks)github user discovery
help wanted

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (PR metrics pending)

Description

The count we show on the "people" icon that leads to the PMs tab can look like this: image I.e., there's a little bubble there… but instead of having a number inside, it's just blank, and so it looks broken.

This happens when the count is 100 or more. Specifically:

  • I got that symptom when logged in as a test account that had 139 unread PMs.
  • Then I went and read the messages one by one from a different client. The symptom stayed the same as the number of unread PMs went down to 100.
  • As soon as the number became 99, it showed up properly: image

I suspect what's happening involves the fact that the number is too long to really fit in that space.

Instead, when this count is big, we should probably just say something like "99+".

Contributor guide