zulip/zulip-mobile

Don't send typing notifications unless `send_private_typing_notifications` setting is enabled.

Open

#5,042 opened on Oct 8, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (673 forks)github user discovery
P1 high-priorityhelp wantedwebapp parity

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (PR metrics pending)

Description

In https://github.com/zulip/zulip/pull/19200, we've added new privacy settings for whether to send typing notifications.

The server will reject typing notification requests if this setting is disabled, so it won't be a user-facing bug to ignore this unless the client-side error handling causes that to be the case. I'll be deploying the feature to CZO soon.

(Note that we're also adding send_stream_typing_notifications, but stream-level typing notifications are not fully implemented yet -- though I think it's mostly client code that's missing and the server implementation is complete). See #4702 for more on that.

Contributor guide

Research direction
Examine the client code that sends typing notifications and add a conditional check for the `send private typing notifications` user setting. Also handle any error responses from the server when the setting is disabled.
Tech stack
javascriptreact native
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70