zulip/zulip-mobile

Action sheets should be in dark theme in night mode

Open

#5,274 opened on Mar 4, 2022

View on GitHub
 (5 comments) (0 reactions) (1 assignee)JavaScript (673 forks)github user discovery
P1 high-prioritybughelp wanted

Repository metrics

Stars
 (1,348 stars)
PR merge metrics
 (PR metrics pending)

Description

When we long-press any stream name, an action sheet will appear from the bottom, which is a streamActionSheet. It should be in dark theme in night mode.

  • Change the background color of the streamActionSheet.
  • Text color should also be changed based on the dark theme i.e., it should be white.

WhatsApp Image 2022-03-04 at 9 25 58 AM (1)

Contributor guide

Research direction
Locate the `streamActionSheet` component in the codebase, likely in a file related to action sheets. Identify the current background and text color styles, then update them to use dark theme colors when night mode is active, referencing existing theme variables for consistency.
Tech stack
javascript
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85